Conversation
It is deprecated by setup-miniconda Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
This should fix the unittests side of pyiron/pyiron_workflow#634 Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
liamhuber
changed the title
Just reference the input directly. Just a bug in the last commit, my bad. Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
|
Verified as working in pyiron/pyiron_workflow#636 |
|
It turns out that fixing this also seems to have resolved what was going wrong with |
|
internal references need to be re-targeted, but that is the last step pre-merge, because we need the branch-specific targeting to test behaviour. |
niklassiemer
left a comment
niklassiemer
left a comment
There was a problem hiding this comment.
As far as I can tell this LGTM!
I have one question to the workflow to change the @commit/tag/branch, though:
Are the @use_miniconda rewritten with the merge? Or do we leave the already merged branch to pin the version until we release a new version and then use @4.0.0?
🚀
Ah, I wish. It is not automated at all right now. Before merging I'll switch the targets all back to I discovered a potential weakness though and discuss it here. I think I'll try it now... |
Per #142 (comment) Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
2 participants
As of five days ago, are getting CI issues. The mamba example on setup-miniconda stopped working too. I can't find or figure out a good direct attack, but mamba is deprecated anyhow so let's see whether it's possible to simply get around the problem by modernizing our setup-miniconda usage.
./-- partially fixes CI failure debugging pyiron_workflow#634sedinvocation for osxIt's been just about a year since v3 dropped, so instead of deprecating the
use_mambaflag, let's just get rid of it, clean up the other deprecated flag, and make a major bump to v4 here.Whatever made the prepended
./in the env names suddenly necessary broke other things too, so I'm hoping it gets rolled back/fixed. However, I don't see that including it here hurts anything, so let's keep it around either way.